Show restored-but-disabled aggregators as ready to enable#107
Merged
Conversation
…onfigured
A restored identity is seeded disabled, so it reports not_installed with
configured=true and rendered as "Not set up" — identical to a never-touched
adapter, making a successful restore look like a no-op. Map that state to a
distinct "Ready to enable" badge, and have the restore summary note that
identities were restored and need enabling to resume feeding.
Also trim the aggregator backup section to {kind, schema_version, aggregators},
dropping the RPC envelope fields (result, protocol_version) that leaked in via
verbatim embedding. Mirrors the Wi-Fi reshape; the lenient importer keeps older
backups loadable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a device backup that includes third-party aggregators seeds each saved identity (sharing keys, feeder IDs) to disk but leaves the adapter disabled — re-enabling is a deliberate manual step, since it triggers the vendor install and resumes feeding your data. The status page rendered that seeded-but-disabled state as "Not set up", indistinguishable from an adapter you never configured, so a successful restore looked like it did nothing.
A restored adapter now reads "Ready to enable" wherever its status badge appears, and the restore checklist tells the operator the identities were restored and just need enabling. The aggregator backup section is also trimmed to the fields it actually needs, dropping a couple of internal RPC envelope fields that were leaking into the saved file; older backups still restore unchanged.